-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C3] chore: update qwik template to use getPlatformProxy
#5010
Conversation
🦋 Changeset detectedLatest commit: 4c17df7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-wrangler-5010 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5010/npm-package-wrangler-5010 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-wrangler-5010 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-create-cloudflare-5010 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-cloudflare-kv-asset-handler-5010 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-miniflare-5010 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-cloudflare-pages-shared-5010 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5010 +/- ##
==========================================
+ Coverage 70.43% 70.49% +0.06%
==========================================
Files 297 297
Lines 15419 15419
Branches 3949 3949
==========================================
+ Hits 10860 10870 +10
+ Misses 4559 4549 -10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks @dario-piotrowicz
What this PR solves / how to test:
This PR updates the C3 Qwik template to use the
getPlatformProxy
utility instead of the deprecatedgetBindingsProxy
oneAuthor has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.